remove the equality and object_hash monkey patching. Its was problematic to port, and not sure it was really useful ? And used for ? (ping @DarkaMaul )

I think it was used to be able to create dict of instructions and/or allow them to be cached.

I force-pushed to rebase it on the current main.
I also change the requirement from pypcode >= 1.1.1 to >= 1.1.2

Just FYI pypcode now is marked as an optional dependency (so install it with pip install quokka-project[pypcode])

remove the equality and object_hash monkey patching. Its was problematic to port, and not sure it was really useful ? And used for ? (ping @DarkaMaul )

I think it was used to be able to create dict of instructions and/or allow them to be cached.

This is the never-ending dilemma about caching/uncaching 😅

I think at the moment there is still a bit of misalignment between what is supposed to be cached and what is not. In QBinDiff and python-binexport we adopted the design choice of having the functions preloaded, the basic blocks by default not cached and everything below basic block (instructions, operands, etc...) as cached by default.
If someone wants to access the basic blocks in a cached way they can either load/unload them manually or by using the python context manager (with statement).

Overall it seems like a good solution that we might enforce on quokka as well. This means also that we might need to reintroduce the equalty and hashing operations at some point.

Maybe we can create an issue as a remainder for enforcing this caching design choice and for now go on and not care about caching pcode objects.

I think changes I made breaks the backward compatibility with older versions of pypcode. Thus we need to enforce pypcode>=2.0.0.

Was the dependency optional previously ? If not I would prefer to leave it as mandatory for ease of use.

I think changes I made breaks the backward compatibility with older versions of pypcode. Thus we need to enforce pypcode>=2.0.0.

Ah sorry, I thought the requirement was for >= 1.1.2

Was the dependency optional previously ? If not I would prefer to leave it as mandatory for ease of use.

It has been optional since fe701ba

Ready to be merged on my side.